Changeset 16 in pacpusframework

Timestamp:

Jan 8, 2013, 1:51:02 AM (12 years ago)

Author:

sgosseli

Message:

Passage by const-reference instead of value.

Location:

trunk

Files:

• include/Pacpus/kernel/ComponentManager.h (modified) (5 diffs)
• src/PacpusLib/ComponentManager.cpp (modified) (10 diffs)

trunk/include/Pacpus/kernel/ComponentManager.h

@@ -66 +66 @@
      * @return Number of components loaded by the manager.
      */
-    PACPUSLIB_API std::size_t loadComponents(QString file);
+    PACPUSLIB_API std::size_t loadComponents(const QString& file);
 
     /** Start all the components
@@ -77 +77 @@
      * @return True if the component exists and has been started, otherwise false.
      */
-    PACPUSLIB_API int start(QString component);
+    PACPUSLIB_API int start(const QString& component);
 
     /** Stop all the components
@@ -88 +88 @@
      * @return True if the component has been stopped, otherwise false.
      */
-    PACPUSLIB_API int stop(QString component);
+    PACPUSLIB_API int stop(const QString& component);
 
     /** Get a pointer to the component referred by @em name.
@@ -94 +94 @@
      * @return Pointer to the component if it exists, otherwise @em NULL.
      */
-    PACPUSLIB_API ComponentBase* getComponent(QString name);
+    PACPUSLIB_API ComponentBase* getComponent(const QString& name);
 
     /** Get the list of all the names of the component known by the manager.
@@ -105 +105 @@
      * @return True if the plugin has been loaded, otherwise false.
      */
-    PACPUSLIB_API bool loadPlugin(QString filename);
+    PACPUSLIB_API bool loadPlugin(const QString& filename);
 
 private:
     /// Create a new component of type 'type' and with the name 'name'
-    bool createComponent(QString type, QString name);
+    bool createComponent(const QString& type, const QString& name);
 
-    bool registerComponent(ComponentBase * addr, QString name);
-    bool registerComponentFactory(ComponentFactoryBase * addr, QString type);
+    bool registerComponent(ComponentBase* addr, const QString& name);
+    bool registerComponentFactory(ComponentFactoryBase* addr, const QString& type);
 
-    bool unRegisterComponent(QString name);
-    bool unRegisterComponentFactory(QString type);
+    bool unRegisterComponent(const QString& name);
+    bool unRegisterComponentFactory(const QString& type);
 
     // Allow 2 functions to access to private members of ComponentManager
-    friend void ComponentFactoryBase::addFactory(ComponentFactoryBase * addr, const QString & type);
+    friend void ComponentFactoryBase::addFactory(ComponentFactoryBase* addr, const QString & type);
     friend void ComponentFactoryBase::addComponent(const QString & name);
 

trunk/src/PacpusLib/ComponentManager.cpp

@@ -54 +54 @@
 }
 
-bool ComponentManager::registerComponentFactory(ComponentFactoryBase * addr, QString type)
+bool ComponentManager::registerComponentFactory(ComponentFactoryBase* addr, const QString& type)
 {
     LOG_TRACE("registerComponentFactory(type="<< type << ")");
@@ -71 +71 @@
 }
 
-bool ComponentManager::unRegisterComponentFactory(QString type)
+bool ComponentManager::unRegisterComponentFactory(const QString& type)
 {
     LOG_TRACE("unRegisterComponentFactory(type="<< type << ")");
@@ -87 +87 @@
 }
 
-bool ComponentManager::registerComponent(ComponentBase * addr, QString name)
+bool ComponentManager::registerComponent(ComponentBase* addr, const QString& name)
 {
     LOG_TRACE("registerComponent(name="<< name << ")");
@@ -103 +103 @@
 }
 
-bool ComponentManager::unRegisterComponent(QString name)
+bool ComponentManager::unRegisterComponent(const QString& name)
 {
     LOG_TRACE("unRegisterComponent(name="<< name << ")");
@@ -121 +121 @@
 }
 
-bool ComponentManager::createComponent(QString type, QString name)
+bool ComponentManager::createComponent(const QString& type, const QString& name)
 {
     LOG_TRACE("createComponent(type=" << type << ", " << "name="<< name << ")");
@@ -136 +136 @@
 }
 
-bool ComponentManager::loadPlugin(QString filename)
+bool ComponentManager::loadPlugin(const QString& filename)
 {
     LOG_TRACE("loadPlugin(filename=" << filename << ")");
@@ -163 +163 @@
 }
 
-std::size_t ComponentManager::loadComponents(QString configFilename)
+std::size_t ComponentManager::loadComponents(const QString& configFilename)
 {
     LOG_TRACE("loadComponents(filename=" << configFilename << ")");
@@ -265 +265 @@
 }
 
-int ComponentManager::start(QString componentName)
+int ComponentManager::start(const QString& componentName)
 {
     LOG_TRACE("start(component=" << componentName << ")");
@@ -297 +297 @@
 }
 
-int ComponentManager::stop(QString componentName)
+int ComponentManager::stop(const QString& componentName)
 {
     LOG_TRACE("stop(component=" << componentName << ")");
@@ -318 +318 @@
 }
 
-ComponentBase * ComponentManager::getComponent(QString name)
+ComponentBase* ComponentManager::getComponent(const QString& name)
 {
     LOG_TRACE("getComponent(name=" << name << ")");