Changeset 216 in pacpusframework for trunk

Timestamp:

Nov 8, 2013, 12:20:22 PM (11 years ago)

Author:

Marek Kurdej

Message:

Modified: NewComponent: using pimpl to separate interface from implementation.

Location:

trunk/src/_NewComponent

Files:

• CMakeLists.txt (modified) (1 diff)
• CMakeLists.txt.in (modified) (4 diffs)
• NewComponent.cpp.in (modified) (5 diffs)
• NewComponent.h.in (modified) (3 diffs)
• NewComponentImpl.cpp.in (added)
• NewComponentImpl.h.in (added)

trunk/src/_NewComponent/CMakeLists.txt

@@ -37 +37 @@
 
 # configure files
-configure_file(CMakeLists.txt.in   "${OUTPUT_DIR}/CMakeLists.txt" @ONLY)
-configure_file(NewComponent.cpp.in "${OUTPUT_DIR}/${PACPUS_COMPONENT_NAME}.cpp" @ONLY)
-configure_file(NewComponent.h.in "${OUTPUT_DIR}/${PACPUS_COMPONENT_NAME}.h" @ONLY)
+configure_file("CMakeLists.txt.in" "${OUTPUT_DIR}/CMakeLists.txt" @ONLY)
+configure_file("NewComponent.h.in" "${OUTPUT_DIR}/${PACPUS_COMPONENT_NAME}.h" @ONLY)
+configure_file("NewComponent.cpp.in" "${OUTPUT_DIR}/${PACPUS_COMPONENT_NAME}.cpp" @ONLY)
+configure_file("NewComponentImpl.h.in" "${OUTPUT_DIR}/${PACPUS_COMPONENT_NAME}Impl.h" @ONLY)
+configure_file("NewComponentImpl.cpp.in" "${OUTPUT_DIR}/${PACPUS_COMPONENT_NAME}Impl.cpp" @ONLY)
 
 ################################################################################

trunk/src/_NewComponent/CMakeLists.txt.in

@@ -27 +27 @@
     ${EXPORT_HDR}
     @PACPUS_COMPONENT_NAME@.h
+    @PACPUS_COMPONENT_NAME@Impl.h
 )
 
@@ -32 +33 @@
     ${PLUGIN_CPP}
     @PACPUS_COMPONENT_NAME@.cpp
+    @PACPUS_COMPONENT_NAME@Impl.cpp
 )
 
@@ -37 +39 @@
     ${PLUGIN_HDR}
     @PACPUS_COMPONENT_NAME@.h
+    @PACPUS_COMPONENT_NAME@Impl.h
 )
 
@@ -77 +80 @@
 # INSTALL
 pacpus_install(${PROJECT_NAME})
+

trunk/src/_NewComponent/NewComponent.cpp.in

@@ -5 +5 @@
 
 #include "@PACPUS_COMPONENT_NAME@.h"
+#include "@PACPUS_COMPONENT_NAME@Impl.h"
 
 #include <Pacpus/kernel/ComponentFactory.h>
@@ -12 +13 @@
 using namespace std;
 
-DECLARE_STATIC_LOGGER("pacpus.base.@PACPUS_COMPONENT_NAME@");
+DECLARE_STATIC_LOGGER("pacpus.@PACPUS_COMPONENT_NAME@");
 
 /// Constructs a static component factory
 static ComponentFactory<@PACPUS_COMPONENT_NAME@> sFactory("@PACPUS_COMPONENT_NAME@");
-
-static const int kDefaultVerboseLevel = 1;
 
 //////////////////////////////////////////////////////////////////////////
@@ -25 +24 @@
     LOG_TRACE("constructor(" << name << ")");
     
-    namespace po = boost::program_options;
     //addParameters()
-    //("parameter-name", po::value<ParameterType>(&mParameterVariable)->required(), "parameter description")
-    //("parameter-name", po::value<ParameterType>(&mParameterVariable)->default_value(0), "parameter description")
+    //("parameter-name", value<ParameterType>(&mImpl->mParameterVariable)->required(), "parameter description")
+    //("parameter-name", value<ParameterType>(&mImpl->mParameterVariable)->default_value(0), "parameter description")
     //;
 }
@@ -53 +51 @@
 void @PACPUS_COMPONENT_NAME@::startActivity()
 {
+    mImpl->start();
 }
 
 void @PACPUS_COMPONENT_NAME@::stopActivity()
 {
+    mImpl->stop();
 }
 
@@ -64 +64 @@
     return ComponentBase::CONFIGURED_OK;
 }
+
+//////////////////////////////////////////////////////////////////////////
+//void @PACPUS_COMPONENT_NAME@::processInput(InputType const& input)
+//{
+//    mImpl->processInput(input);
+//}

trunk/src/_NewComponent/NewComponent.h.in

@@ -20 +20 @@
 #include <Pacpus/kernel/ComponentBase.h>
 
+#include <boost/scoped_ptr.hpp>
 #include <QObject>
 
-namespace pacpus {
+namespace pacpus
+{
 
 class @PACPUS_COMPONENT_NAME_CAPS@_API @PACPUS_COMPONENT_NAME@
@@ -49 +51 @@
     
 private:
-    //void processInput(const InputType & input);
+    //void processInput(InputType const& input);
 
 private:
+    struct Impl;
+    boost::scoped_ptr<Impl> mImpl;
 };
 
@@ -57 +61 @@
 
 #endif // @PACPUS_COMPONENT_NAME_CAPS@_H
-