Changeset 288 in pacpusframework for trunk/src/PacpusLib

Timestamp:

03/26/14 21:27:30 (10 years ago)

Author:

Marek Kurdej

Message:

Using boost::shared_ptr for storing components.

Location:

trunk/src/PacpusLib

Files:

• ComponentBase.cpp (modified) (5 diffs)
• ComponentFactoryBase.cpp (modified) (4 diffs)
• ComponentManager.cpp (modified) (18 diffs)
• XmlComponentConfig.cpp (modified) (6 diffs)

trunk/src/PacpusLib/ComponentBase.cpp

@@ -17 +17 @@
 #include <boost/program_options/parsers.hpp>
 #include <boost/program_options/variables_map.hpp>
-#include <boost/thread/thread.hpp>
+//#include <boost/thread/thread.hpp>
 #include <ostream>
 #include <string>
@@ -77 +77 @@
 DECLARE_STATIC_LOGGER("pacpus.core.ComponentBase");
 
-ComponentBase::ComponentBase(const QString & componentName)
+ComponentBase::ComponentBase(QString const& componentName)
     : m_componentName(componentName)
     , m_isActive(false)
@@ -131 +131 @@
 }
 
-void ComponentBase::startComponentWithException(boost::exception_ptr& error)
-{
-    try {
-        startActivity();
-        error = boost::exception_ptr();
-    } catch (...) {
-        error = boost::current_exception();
-    }
-}
-
-void ComponentBase::startComponentInThread()
-{
-    boost::exception_ptr error;
-    boost::thread t(
-        boost::bind(
-            &ComponentBase::startComponentWithException,
-            this,
-            boost::ref(error)
-        )
-    );
-    t.join();
-    if (error) {
-        try {
-            boost::rethrow_exception(error);
-        } catch (boost::exception& e) {
-            LOG_FATAL("[" << getName() << "]" << "\tboost::exception thrown: " << boost::diagnostic_information(e));
-            //throw;
-        }
-    }
-}
+//void ComponentBase::startComponentWithException(boost::exception_ptr& error)
+//{
+//    try {
+//        startActivity();
+//        error = boost::exception_ptr();
+//    } catch (...) {
+//        error = boost::current_exception();
+//    }
+//}
+//
+//void ComponentBase::startComponentInThread()
+//{
+//    boost::exception_ptr error;
+//    boost::thread t(
+//        boost::bind(
+//            &ComponentBase::startComponentWithException,
+//            this,
+//            boost::ref(error)
+//        )
+//    );
+//    t.join();
+//    if (error) {
+//        try {
+//            boost::rethrow_exception(error);
+//        } catch (boost::exception& e) {
+//            LOG_FATAL("[" << getName() << "]" << "\tboost::exception thrown: " << boost::diagnostic_information(e));
+//            //throw;
+//        }
+//    }
+//}
 
 int ComponentBase::startComponent()
@@ -170 +170 @@
 
     setActive(true);
-    boost::thread worker(&ComponentBase::startComponentInThread, this);
-    //boost::thread worker(&ComponentBase::startActivity, this);
-    //startActivity();
+    //boost::thread worker(&ComponentBase::startComponentInThread, this);
+    startActivity();
+    //moveToThread(&mThread);
+    //mThread.start();
     return true;
 }
@@ -185 +186 @@
     setActive(false);
     stopActivity();
-    
+    //QMetaObject::invokeMethod(&mThread, "quit");
     return true;
 }

trunk/src/PacpusLib/ComponentFactoryBase.cpp

@@ -10 +10 @@
 #include <Pacpus/kernel/Log.h>
 
-#include <cassert>
+#include <boost/assert.hpp>
 #include <QString>
 
@@ -23 +23 @@
     // get the adress of the ComponentManager instance
     mgr_ = ComponentManager::getInstance();
+    BOOST_ASSERT(mgr_);
 }
 
@@ -30 +31 @@
 }
 
-void ComponentFactoryBase::addFactory(ComponentFactoryBase* addr, const QString& type)
+void ComponentFactoryBase::addFactory(ComponentFactoryBase* addr, QString const& type)
 {
     LOG_DEBUG("addFactory(type="<< type << ")");
 
-    assert(mgr_);
     if (!mgr_->registerComponentFactory(addr, type)) {
         /*
@@ -44 +44 @@
 }
 
-void ComponentFactoryBase::addComponent(const QString& name)
+void ComponentFactoryBase::createComponent(QString const& name)
 {
     LOG_DEBUG("addComponent(" << name << ")");
 
-    // FIXME: instantiated component is never deleted!
-    // who should do it? ComponentManager?
-    ComponentBase * addr = instantiateComponent(name);
-    assert(mgr_);
-    if (!mgr_->registerComponent(addr, name)) {
-        delete addr;
-        addr = NULL;
-    }
+    ComponentSharedPointer component = instantiateComponent(name);
+    mgr_->registerComponent(component, name);
 }

trunk/src/PacpusLib/ComponentManager.cpp

@@ -125 +125 @@
 }
 
-bool ComponentManager::registerComponentFactory(ComponentFactoryBase* addr, const QString& type)
+bool ComponentManager::registerComponentFactory(ComponentFactoryBase* addr, QString const& type)
 {
     LOG_TRACE("registerComponentFactory(type="<< type << ")");
@@ -141 +141 @@
 }
 
-bool ComponentManager::unregisterComponentFactory(const QString& type)
+bool ComponentManager::unregisterComponentFactory(QString const& type)
 {
     LOG_TRACE("unregisterComponentFactory(type="<< type << ")");
@@ -156 +156 @@
 }
 
-bool ComponentManager::registerComponent(ComponentBase* addr, const QString& name)
+bool ComponentManager::registerComponent(boost::shared_ptr<ComponentBase> addr, QString const& name)
 {
     LOG_TRACE("registerComponent(name="<< name << ")");
@@ -171 +171 @@
 }
 
-bool ComponentManager::unregisterComponent(const QString& name)
+bool ComponentManager::unregisterComponent(QString const& name)
 {
     LOG_TRACE("unregisterComponent(name="<< name << ")");
@@ -180 +180 @@
     }
 
-    // FIXME: delete component
-    ComponentBase* component = componentMap_.value(name, NULL);
-    //delete component;
-
+    boost::shared_ptr<ComponentBase> component = componentMap_.value(name, NULL);
+    
     // FIXME: remove from map (causes segfault in QMap::qMapLessThanKey on Windows)
     //componentMap_.remove(name);
     LOG_INFO("unregistered component '" << name << "'");
-
-    return true;
-}
-
-bool ComponentManager::createComponent(const QString& type, const QString& name)
+    return true;
+}
+
+bool ComponentManager::createComponent(QString const& type, QString const& name)
 {
     LOG_TRACE("createComponent(type=" << type << ", " << "name="<< name << ")");
@@ -198 +195 @@
         ComponentFactoryBase* factory = factoryMap_.value(type);
         assert(factory);
-        factory->addComponent(name);
+        factory->createComponent(name);
         return true;
     }
@@ -209 +206 @@
 }
 
-bool ComponentManager::loadPlugin(const QString& filename)
+bool ComponentManager::loadPlugin(QString const& filename)
 {
     LOG_TRACE("loadPlugin(filename=" << filename << ")");
@@ -236 +233 @@
 }
 
-bool ComponentManager::checkComponent(const QString & componentName)
+bool ComponentManager::checkComponent(QString const& componentName)
 {
     if (NULL == getComponent(componentName)) {
@@ -245 +242 @@
 }
 
-bool ComponentManager::checkComponentInput(const QString & componentName, const QString & inputName)
+bool ComponentManager::checkComponentInput(QString const& componentName, QString const& inputName)
 {
     if (!checkComponent(componentName)) {
@@ -257 +254 @@
 }
 
-bool ComponentManager::checkComponentOutput(const QString & componentName, const QString & outputName)
+bool ComponentManager::checkComponentOutput(QString const& componentName, QString const& outputName)
 {
     if (!checkComponent(componentName)) {
@@ -269 +266 @@
 }
 
-bool ComponentManager::createConnection(const QString & outputSignature, const QString & inputSignature, const QString & type, int priority = 0)
+bool ComponentManager::createConnection(QString const& outputSignature, QString const& inputSignature, QString const& type, int priority = 0)
 {
     // FIXME: use 2 signatures (output component + output connection) instead of 1 separated by a (".") dot
@@ -289 +286 @@
 }
 
-std::size_t ComponentManager::loadComponents(const QString& configFilename)
+std::size_t ComponentManager::loadComponents(QString const& configFilename)
 {
     LOG_TRACE("loadComponents(filename=" << configFilename << ")");
@@ -334 +331 @@
 
         // copy locally the config parameters of the component
-        ComponentBase * component = getComponent(componentName);
+        ComponentSharedPointer component = getComponent(componentName);
         if (NULL == component) {
             LOG_WARN("component '" << componentName << "' does not exist");
@@ -356 +353 @@
         QString componentName = cfg.getComponentName();
 
-        ComponentBase * component = getComponent(componentName);
-        if (NULL == component) {
+        ComponentSharedPointer component = getComponent(componentName);
+        if (!component) {
             LOG_WARN("component '" << componentName << "' does not exist");
             continue;
@@ -430 +427 @@
 }
 
-bool ComponentManager::start(const QString & componentName)
+bool ComponentManager::start(QString const& componentName)
 {
     LOG_TRACE("start(component=" << componentName << ")");
 
-    ComponentBase* component = getComponent(componentName);
+    ComponentSharedPointer component = getComponent(componentName);
     if (!component) {
         LOG_WARN("cannot start component '" << componentName << "'.  It does not exist!");
@@ -465 +462 @@
 }
 
-bool ComponentManager::stop(ComponentBase * component) const
+bool ComponentManager::stop(ComponentSharedPointer component) const
 {
     if (!component) {
@@ -477 +474 @@
 }
 
-bool ComponentManager::stop(const QString & componentName)
+bool ComponentManager::stop(QString const& componentName)
 {
     LOG_TRACE("stop(component=" << componentName << ")");
 
-    ComponentBase* component = getComponent(componentName);
+    ComponentSharedPointer component = getComponent(componentName);
     if (!component) {
         LOG_WARN("cannot stop component '" << componentName << "'" << ". It does not exist");
@@ -495 +492 @@
 }
 
-ComponentBase * ComponentManager::getComponent(const QString & name)
+ComponentSharedPointer ComponentManager::getComponent(QString const& name)
 {
     LOG_TRACE("getComponent(name=" << name << ")");

trunk/src/PacpusLib/XmlComponentConfig.cpp

@@ -22 +22 @@
 static const char* kPropertyConnectionPriority = "priority";
 
-XmlComponentConfig::XmlComponentConfig(const QString& name)
+XmlComponentConfig::XmlComponentConfig(QString const& name)
 {
     LOG_TRACE("XmlComponentConfig(QString)");
@@ -43 +43 @@
 }
 
-void XmlComponentConfig::addProperty(const QString& name)
+void XmlComponentConfig::addProperty(QString const& name)
 {
     if (hasProperty(name)) {
@@ -62 +62 @@
 }
 
-int XmlComponentConfig::delProperty(const QString& name)
+int XmlComponentConfig::delProperty(QString const& name)
 {
     if (!hasProperty(name)) {
@@ -82 +82 @@
 }
 
-QString XmlComponentConfig::getProperty(const QString& name, const QString& defaultValue) const
+QString XmlComponentConfig::getProperty(QString const& name, QString const& defaultValue) const
 {
     if (!hasProperty(name))
@@ -97 +97 @@
 }
 
-bool XmlComponentConfig::getBoolProperty(const QString& name, bool defaultValue) const
+bool XmlComponentConfig::getBoolProperty(QString const& name, bool defaultValue) const
 {
   return hasProperty(name) ? getProperty(name) == "true" : defaultValue;
 }
 
-int XmlComponentConfig::getIntProperty(const QString& name, int defaultValue) const
+int XmlComponentConfig::getIntProperty(QString const& name, int defaultValue) const
 {
   return hasProperty(name) ? getProperty(name).toInt() : defaultValue;
 }
 
-double XmlComponentConfig::getDoubleProperty(const QString& name, double defaultValue) const
+double XmlComponentConfig::getDoubleProperty(QString const& name, double defaultValue) const
 {
   return hasProperty(name) ? getProperty(name).toDouble() : defaultValue;
 }
 
-void XmlComponentConfig::setProperty(const QString& name, const QString& value)
+void XmlComponentConfig::setProperty(QString const& name, QString const& value)
 {
     component_.setAttribute(name, value);
@@ -121 +121 @@
 }
 
-bool XmlComponentConfig::hasProperty(const QString& name) const
+bool XmlComponentConfig::hasProperty(QString const& name) const
 {
     return component_.hasAttribute(name);