Changeset 30 in pacpusframework for trunk/src

Timestamp:

Jan 8, 2013, 5:32:28 PM (12 years ago)

Author:

sgosseli

Message:

Major: improve the documentation of ComponentBase and use the new include style.

File:

• trunk/src/PacpusLib/ComponentBase.cpp (modified) (4 diffs)

trunk/src/PacpusLib/ComponentBase.cpp

@@ -8 +8 @@
 *********************************************************************/
 
-#include "kernel/ComponentBase.h"
+#include <Pacpus/kernel/ComponentBase.h>
+#include <Pacpus/kernel/ComponentManager.h>
+#include <Pacpus/kernel/Log.h>
 
-#include "kernel/ComponentManager.h"
-#include "kernel/Log.h"
-
-namespace pacpus {
+using namespace pacpus;
 
 DECLARE_STATIC_LOGGER("pacpus.core.ComponentBase");
 
-ComponentBase::ComponentBase(QString name)
+ComponentBase::ComponentBase(const QString& name)
 {
     LOG_TRACE("constructor");
@@ -40 +39 @@
     LOG_TRACE("destructor");
 }
-
-//TODO
-//COMPONENT_CONFIGURATION ComponentBase::configureComponent(XmlComponentConfig config)
-//{
-//}
 
 int ComponentBase::startComponent()
@@ -75 +69 @@
 }
 
-// return the state of the component 
+// FIXME: this should be const.
 ComponentBase::COMPONENT_STATE ComponentBase::getState()
 {
@@ -85 +79 @@
 }
 
-} // namespace pacpus
+bool ComponentBase::isConfigured() const
+{
+    return CONFIGURED_OK == configuration_;
+}